Re: [PATCH] ulpi: add i.MX25 & 35 internal PHY ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Eric BÃnard wrote:

without this patch, the initialization of the OTG port in host mode
fails with :
ehci_hcd: USB 2.0 'Enhanced' Host Controller (EHCI) Driver
mxc-ehci mxc-ehci.0: initializing i.MX USB Controller
ULPI transceiver vendor/product ID 0x0000/0x0000
ULPI ID does not match any known transceiver.
mxc-ehci mxc-ehci.0: unable to init transceiver, probably missing

Signed-off-by: Eric BÃnard <eric@xxxxxxxxxx>
---
 drivers/usb/otg/ulpi.c |    5 ++++-
 1 files changed, 4 insertions(+), 1 deletions(-)

   You should have CC'ed linux-usb@xxxxxxxxxxxxxxxx

diff --git a/drivers/usb/otg/ulpi.c b/drivers/usb/otg/ulpi.c
index ccc8195..e802e44 100644
--- a/drivers/usb/otg/ulpi.c
+++ b/drivers/usb/otg/ulpi.c
@@ -34,7 +34,10 @@
 /* ULPI hardcoded IDs, used for probing */
 static unsigned int ulpi_ids[] = {
 	ULPI_ID(0x04cc, 0x1504),	/* NXP ISP1504 */
-	ULPI_ID(0x0424, 0x0006),        /* SMSC USB3319 */
+	ULPI_ID(0x0424, 0x0006),	/* SMSC USB3319 */
+#if (defined(CONFIG_ARCH_MX25) || defined(CONFIG_ARCH_MX35))
+	ULPI_ID(0x0000, 0x0000),	/* i.MX25 & i.MX35 internal PHY */
+#endif

I don't know why this table is at all used in the first place. IMO, checking for the vendor/device ID serves no purpose...

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux