Re: [PATCH 1/3] USB: usbtest fix coding style

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



[Adding the mailing list back]
On Sat, Oct 2, 2010 at 4:32 AM, David Brownell <david-b@xxxxxxxxxxx> wrote:
> If you're going to do this, I'd rather see just
> one patch vs two ... and with a comment saying
> what you're doing.

Sorry, I don't understand. There are three patches in the
series, one to fix coding style, one to check isoc length
and one to add the unaligned buffer tests.

Are you saying I should merge all this into a single
patch?


> Simpler perhaps if you just make it pass the
> current "checkpatch --file".
>
That's basically what I did (except I didn't
know about --file so created a dummy patch
against /dev/null and ran checkpatch on that :)

I did leave in two checkpatch errors for
//#define	IBOT2		/* grab iBOT2 webcams */
//#define	KEYSPAN_19Qi	/* grab un-renumerated serial adapter */

because it's much easier to just remove the // to activate

Martin
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux