Re: [PATCH 3/3] USB: usbtest : Add tests to ensure HCDs can accept byte aligned buffers.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > Instead of adding new tests,
> would it be better to add a new parameter
> > to the existing tests?

My two cents:  no.  I'd rather have focussed tests.
Having parameters at all was just a hack to let me
access more tests through what started out as a very
narrow bandwidth access method.  And ISTR that the
params were limited:  size, count, little else (at
first).

In terms of test design, it's best not to overload
stuff.

That said, including alignment tests in some of the
current code might be OK ... though it'd be more
clear just to have separate (and properly commented)
tests focussed on just this "is the controller driver
being stupid/incorrect) issue.

An advantage of merging an alignment test with some
of the others would be that existing test scripts
might not need modification to pick up that extra
test/code coverage ...

- Dave



--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux