On Tue, 28 Sep 2010, Matthew Wilcox wrote: > > Now that a single URB can transmit a SG list, we can remove the > usb_sg_init / usb_sg_wait / usb_sg_cancel API. It only has two users -- > usb-storage and usbtest. > > I have not tested this patch! I'm currently travelling and would prefer > not to test it on my laptop. The diffstat is quite compelling though, > and the usb-storage driver gets quite a lot simpler (net -31 lines of > code from that driver). This is a nice idea in principle, but the premise is flawed. It's not true that a single URB can transmit an SG list -- this capability is present in some host controller drivers but not in all of them. For example, ohci-hcd and uhci-hcd can't do it (although a patch was posted just this morning adding this feature to uhci-hcd). Therefore NAK. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html