From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> I've noticed that musb_gadget_queue() checks for '!req->buf' condition twice: in the second case the code is both duplicate and unreachable as the first check returns early. Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx> Signed-off-by: Felipe Balbi <balbi@xxxxxx> --- drivers/usb/musb/musb_gadget.c | 2 -- 1 files changed, 0 insertions(+), 2 deletions(-) diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c index 2aba817..f3859a8 100644 --- a/drivers/usb/musb/musb_gadget.c +++ b/drivers/usb/musb/musb_gadget.c @@ -1214,8 +1214,6 @@ static int musb_gadget_queue(struct usb_ep *ep, struct usb_request *req, if (is_dma_capable() && musb_ep->dma) map_dma_buffer(request, musb); - else if (!req->buf) - return -ENODATA; else request->mapped = 0; -- 1.7.3.rc0.35.g8ac8c -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
