Re: [PATCH] USB: musb_gadget: fix ZLP sending in musb_g_tx(v1)

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 22, 2010 at 10:15:09AM -0500, tom.leiming@xxxxxxxxx wrote:
From: Ming Lei <tom.leiming@xxxxxxxxx>

This patch fixes the problem reported by Sergei:

how come? we need to send ZLP before giving back the request.
Well, look at the code ionce again. We need to send ZLP *after*
request->actual == request->length, but as the check is inserted
after the ZLP send, ZLP *may* be sent once the first DMA completes,
not the last.

The patch also has been discussed on the link below:

	http://marc.info/?t=128454814900001&r=1&w=2

Signed-off-by: Ming Lei <tom.leiming@xxxxxxxxx>
Reported-by:   Sergei Shtylyov <sshtylyov@xxxxxxxxxx>
Cc: Felipe Balbi <balbi@xxxxxx>
Cc: David Brownell <dbrownell@xxxxxxxxxxxxxxxxxxxxx>
Cc: Anand Gadiyar <gadiyar@xxxxxx>
Cc: Mike Frysinger <vapier@xxxxxxxxxx>
Cc: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

applied, thanks.

Still passing testusb, I'll leave it still running for the rest of the
day to see what comes out of it :-)

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux