On Thu, Sep 23, 2010 at 03:36:40AM -0500, Ming Lei wrote:
2010/9/23 Felipe Balbi <balbi@xxxxxx>:
Hi,
On Wed, Sep 22, 2010 at 10:15:09AM -0500, tom.leiming@xxxxxxxxx wrote:
+ if ((request->zero && request->length
I think you can actually remove the request->length check, I doubt any
gadget driver will queue a request without length sent to something more
than 0. could you test that please ?
I think so too. But I am not sure, since I don't know why the
request->length check is introduced, so I don't remove the check in
the patch and just fix the ZLP issue only.
Also seems req->zero is used in some corner case only, I don't think
there are good test cases to verify the change of removing the check,
right?
So suggest to keep the check until we are sure it is safe to remove it.
makes sense :-) I'll try to play around with removing request->length
check after merge window then :-)
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
