Re: [PATCH 9/9 v3] usb : musb: Offmode fix for idle path

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Thu, Sep 23, 2010 at 02:59:29AM -0500, Kalliguddi, Hema wrote:
Oh! It should be core. Now I understand why save/restore counts were not matching with
Core-off counts.
Thanks for pointing this out.

ok, please be more careful next time, we could have committed without
noticing this :-)

if plat->save_context is 1, then set it to 1 ???

This is mistake. I messed it up. I had another flag
for offmode support, which I removed later.
i will correct this.

ok.

@@ -2443,10 +2447,13 @@ static int musb_resume_noirq(struct devi
{
	struct platform_device *pdev = to_platform_device(dev);
	struct musb	*musb = dev_to_musb(&pdev->dev);

just now I notice these, hah, funny :-p pdev isn't even
needed. Has been
there for quite a while I believe.

Commit 48fea965 should have changed that line, but that's ok, we will
clean it later.

Yehh :-)
If it is OK, I can clean it up with this patch only.

nope, it's not part of this patch. leave it as is for now.

--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux