Hi, >-----Original Message----- >From: Balbi, Felipe >Sent: Thursday, September 23, 2010 11:53 AM >To: Cousson, Benoit >Cc: Kalliguddi, Hema; linux-omap@xxxxxxxxxxxxxxx; >linux-usb@xxxxxxxxxxxxxxx; Basak, Partha; Balbi, Felipe; Tony >Lindgren; Kevin Hilman; Paul Walmsley >Subject: Re: [PATCH 7/9 v3] OMAP: Hwmod api changes > >On Wed, Sep 22, 2010 at 03:43:14PM -0500, Cousson, Benoit wrote: >>Hi Hema, >> >>On 9/23/2010 2:30 AM, Kalliguddi, Hema wrote: >>> OMAP USBOTG modules has a requirement to set the auto idle >bit only after >>> setting smart idle bit. Modified the _sys_enable api to set >the smart idle >>> first and then the autoidle bit. Setting this will not have >any impact on the >>> other modules. >> >>I think you should change the subject, because it does not reflect >>accurately the patch. >> >>Just a little bit of nitpicking... >>For me, an API change is a change in the signature of the API, not a >>change inside an API. Otherwise, since 99% of the code is inside a >>function, we can call most patches like that... >>Moreover I don't think _sysc_enable can be considered as an >API since it >>is a pure static helper function not exported to the outside. >> >>Something like that seems more accurate for my point of view: >> >>OMAP: hwmod: Set autoidle after smartidle during _sysc_enable > >+1 > I Agree. I will do the changes accordingly and post the patch. >-- >balbi >-- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
