On Wed, Sep 22, 2010 at 11:03:16AM +0200, ext Felipe Balbi wrote: >Hi, > >On Wed, Sep 22, 2010 at 04:01:03AM -0500, Heikki Krogerus wrote: >>> to me, you should always notify calls to usb_gadget_vbus_draw(), even if >>> it's enumerated with 0mA. It'll help us tracing down problems with >>> gadget drivers. If there are any. >> >>Fair enough, but I would like to avoid resending notifications with >>the same mA. > >but why would that happen ? Only if host is selecting same configuration >twice :-p Or some driver is calling usb_gadget_vbus_draw() at the wrong >location. If I remove the 0mA condition, I'm seeing first 100mA notification then 0, 100 again and finally 500 from the configuration. This is a lot of notifications, but I guess you are correct. Let's remove all conditions. -- heikki -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html