I've noticed that musb_gadget_queue() checks for '!req->buf' condition twice:
in the second case the code is both duplicate and unreachable as the first
check returns early.
Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
---
The patch is against the recent Linus' tree; it's intended for 2.6.37...
drivers/usb/musb/musb_gadget.c | 2 --
1 file changed, 2 deletions(-)
Index: linux-2.6/drivers/usb/musb/musb_gadget.c
===================================================================
--- linux-2.6.orig/drivers/usb/musb/musb_gadget.c
+++ linux-2.6/drivers/usb/musb/musb_gadget.c
@@ -1144,8 +1144,6 @@ static int musb_gadget_queue(struct usb_
: DMA_FROM_DEVICE);
request->mapped = 0;
}
- } else if (!req->buf) {
- return -ENODATA;
} else
request->mapped = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
