Hello Greg, can you pick this up? > The protocol code is set 00 in IAD and it's set to 01 in ACM > control interface descriptor in f_acm.c file. Due to this, > windows is unable to install the modem(ACM) driver based on > class-subclass-protocol matching. > > This patch corrects the protocol code in ACM IAD to the same > as in acm_control_interface_desc protocol code. > > Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxxxxxx> > Signed-off-by: Praveena Nadahally <praveen.nadahally@xxxxxxxxxxxxxx> > --- > drivers/usb/gadget/f_acm.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/usb/gadget/f_acm.c b/drivers/usb/gadget/f_acm.c > index d47a123..bd6226c 100644 > --- a/drivers/usb/gadget/f_acm.c > +++ b/drivers/usb/gadget/f_acm.c > @@ -111,7 +111,7 @@ acm_iad_descriptor = { > .bInterfaceCount = 2, // control + data > .bFunctionClass = USB_CLASS_COMM, > .bFunctionSubClass = USB_CDC_SUBCLASS_ACM, > - .bFunctionProtocol = USB_CDC_PROTO_NONE, > + .bFunctionProtocol = USB_CDC_ACM_PROTO_AT_V25TER, > /* .iFunction = DYNAMIC */ > }; > > -- > 1.6.3.3 -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html