2010/9/18 Sergei Shtylyov <sshtylyov@xxxxxxxxxx>: >> We have discussed the patch for some time already, why do you say >> original code again? > > I was discussing the approach, not your patch. If we talk in code or patch, the discuss may be more efficient, right? > >> For the patch, it is more clear than original code in logic: >> - handle zlp or short packet first if one of two conditions is true >> - complete the request if data transfer is over > > Both these should be done when (request->actual == request->length), > that's my point. OK, If we are sure that request->actual is equal to request->length for the short packet case, doing the check once is enough. Felipe, the revised patch will be sending out later to you... -- Lei Ming -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
