Re: [patch-2.6.36+ 07/12] usb: musb: make DBG() calls actually depend on CONFIG_USB_MUSB_DEBUG

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Sep 16, 2010 at 09:56:07AM +0300, Felipe Balbi wrote:
> From: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
> 
> Enabling CONFIG_USB_MUSB_DEBUG option causes -DDEBUG to be added to gcc's
> command line, however the DBG() macro doesn't depend on DEBUG, so that the
> debugging messages get printed regardless of the option, and I don't think
> that this was intended. Make xprintk() macro used by DBG() call pr_debug()
> which only results in the actual code generated if DEBUG is defined.
> 
> This change makes musb_hdrc.o ~30% less in size with CONFIG_USB_MUSB_DEBUG
> disabled (in host mode).
> 
> Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>

Is this really a regression that should be going in so late in the
.36-rc release cycle?

I don't think so.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux