Re: EHCI post reset callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 13 Sep 2010, Pavan Kondeti wrote:

> Hi
> 
> I am developing HCD for MSM USB hardware. The controller is compliant to EHCI.
> But we need to initialize non-EHCI registers after controller is reset. This
> also include workarounds like disabling streaming mode etc.
> 
> Due to this, we can not initialize .start method of struct hc_driver to
> ehci_run. This function call ehci_reset (after this hardware register settings
> are lost) and continue initialization of controller.
> 
> Is it okay to introduce a callback function in ehci_hcd struct that gets called
> right after ehci_reset()? I have added this method to ehci_hcd instead of hc_driver
> struct thinking that this is more like a silicon quirk.

Maybe you can simply remove the ehci_reset call from ehci_run.  I don't
see any reason why it is needed there.

But if you do then you will have to add calls to ehci_reset in drivers
like ehci-au1xxx, ehci-omap, and ehci-w90x900, which otherwise wouldn't
call it.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux