On Fri, 10 Sep 2010, Greg KH wrote: > On Fri, Sep 10, 2010 at 03:14:44PM -0400, Alan Stern wrote: > > The /sys/kernel/debug/usb/devices file doesn't know about Wireless or > > SuperSpeed USB. This patch (as1416) teaches it. > > > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > > CC: David Vrabel <david.vrabel@xxxxxxx> > > CC: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx> > > > > --- > > > > I wasn't sure what to put in the Wireless case. The string I chose has > > the disadvantage of not being a number, so it might confuse programs > > that try to parse it. If anyone has a better suggestion, let me know. > > There are tools that parse this value, so we can't make it a string :( Do these tools assume particular field widths? If they do, how will they cope with a 4-digit SuperSpeed entry? > > Even the SuperSpeed case is (in theory) variable. But for now we don't > > support anything other than 5 billion bits per second. > > That's fine. Do we care about the speed of wireless devices? Don't we > know that somehow? Personally I don't care about the exact speed. But the field should contain a value that will let the reader know the device is using a wireless link. David, any ideas? > Oh, and you need to update the Documentation/usb/proc_usb_info.txt file > when you make this change. Will do. In fact that file is out of date in several ways, not least of which is its name. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
