On Thu, Sep 09, 2010 at 09:12:44AM -0500, Sergei Shtylyov wrote:
Sergei Shtylyov wrote:
Enabling CONFIG_USB_MUSB_DEBUG option causes -DDEBUG to be added to
gcc's
command line, however the DBG() macro doesn't depend on DEBUG, so
that the
debugging messages get printed regardless of the option, and I don't
think
that this was intended. Make xprintk() macro used by DBG() call
pr_debug()
which only results in the actual code generated if DEBUG is defined.
This change makes musb_hdrc.o ~30% less in size with
CONFIG_USB_MUSB_DEBUG
disabled (in host mode).
Signed-off-by: Sergei Shtylyov <sshtylyov@xxxxxxxxxxxxx>
FWIW, I believe this patch is good to have and should not be lost again.
This doesn't matter one way or another to me, but I'm curious...
Instead of changing the xprintk macro so drastically,
The only change there is dropping of the explicit debug facility
(which was always KERN_DEBUG anyway). Alternatively, I could get rid of
the whole xprintk() macro, renaming it to DBG().
why not just
make the DBG macro depend on DEBUG? After all, that is the real
problem as given in the patch description.
With changing xprintk() to using pr_debug() we get shorter code.
Acked-by: Anand Gadiyar <gadiyar@xxxxxx>
Felipe, ping. What's your opinion on thios patch? We've just missed
another merge window but maybe this will do as a bug fix?
Asking you again, at your new address...
I'll pick it up but can only send to Greg when I get HW to test.
--
balbi
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
