On Mon, 6 Sep 2010, Matthieu CASTET wrote: > tdi_reset is already taking care of setting host mode. Don't duplicate > code in platform driver. > > Also make ehci_halt a nop if the controller is not in ehci mode, > otherwise the halt will fail. > > > Signed-off-by: Matthieu CASTET <matthieu.castet@xxxxxxxxxx> This looks like several different patches all rolled up into one. The patch description mentions two different things, and there are also those hcd->has_tt changes which aren't described at all. The name "tdi_is_ehci" is confusing. Besides being very similar to "ehci_is_TDI", its meaning isn't clear. What other mode besides EHCI could the TDI/ARC hardware be in? Should the name be something more like "tdi_in_host_mode"? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
