On Fri, 6 Aug 2010, Nikolai Kondrashov wrote:
> Add support for UC-Logic WP4030U, WP5540U and WP8060U tablets.
> These tablets are usually sold by Genius, Trust and possibly others under
> different names and in different cases, but with the original USB
> vendor/product IDs.
>
> Currently, these tablets are supported by standalone X.org driver WizardPen.
> This patch aims to fix them in the kernel and make them supported by the
> generic evdev X.org driver. Still, some minor fixes in the X.org driver are
> to be made for the full stack support.
>
> Signed-off-by: Nikolai Kondrashov <spbnick@xxxxxxxxx>
Hi Nikolai,
thanks a lot for the patches. Generally, everything seems sane. Just a few
comments below.
> ---
> drivers/hid/Kconfig | 7 +
> drivers/hid/Makefile | 1 +
> drivers/hid/hid-core.c | 3 +
> drivers/hid/hid-ids.h | 2 +
> drivers/hid/hid-uclogic.c | 404 +++++++++++++++++++++++++++++++++++++++
> drivers/hid/usbhid/hid-quirks.c | 3 +-
> 6 files changed, 419 insertions(+), 1 deletions(-)
> create mode 100644 drivers/hid/hid-uclogic.c
>
> diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig
> index 6369ba7..43335bd 100644
> --- a/drivers/hid/Kconfig
> +++ b/drivers/hid/Kconfig
> @@ -176,6 +176,13 @@ config HID_KYE
> ---help---
> Support for Kye/Genius Ergo Mouse.
>
> +config HID_UCLOGIC
> + tristate "UC-Logic" if EMBEDDED
> + depends on USB_HID
> + default !EMBEDDED
Please remove the 'default !EMBEDDED' thing. After some debtaes with
Linus, we are now having these only for a small/limited subset of
functionality, not "normal" standalone drivers on a HID bus.
> + ---help---
> + Support for UC-Logic tablets.
> +
> config HID_GYRATION
> tristate "Gyration"
> depends on USB_HID
> diff --git a/drivers/hid/Makefile b/drivers/hid/Makefile
> index 46f037f..1e17067 100644
> --- a/drivers/hid/Makefile
> +++ b/drivers/hid/Makefile
> @@ -38,6 +38,7 @@ obj-$(CONFIG_HID_EZKEY) += hid-ezkey.o
> obj-$(CONFIG_HID_GYRATION) += hid-gyration.o
> obj-$(CONFIG_HID_KENSINGTON) += hid-kensington.o
> obj-$(CONFIG_HID_KYE) += hid-kye.o
> +obj-$(CONFIG_HID_UCLOGIC) += hid-uclogic.o
> obj-$(CONFIG_HID_LOGITECH) += hid-logitech.o
> obj-$(CONFIG_HID_MAGICMOUSE) += hid-magicmouse.o
> obj-$(CONFIG_HID_MICROSOFT) += hid-microsoft.o
Please keep this list sorted, thanks.
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 2643d31..162aa4b 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -68,7 +68,8 @@ static const struct hid_blacklist {
> { USB_VENDOR_ID_SUN, USB_DEVICE_ID_RARITAN_KVM_DONGLE, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_TURBOX, USB_DEVICE_ID_TURBOX_KEYBOARD, HID_QUIRK_NOGET },
> { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_PF1209, HID_QUIRK_MULTI_INPUT },
> - { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_WP4030U, HID_QUIRK_MULTI_INPUT },
> + { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_WP5540U, HID_QUIRK_MULTI_INPUT },
> + { USB_VENDOR_ID_UCLOGIC, USB_DEVICE_ID_UCLOGIC_TABLET_WP8060U, HID_QUIRK_MULTI_INPUT },
How come it is suddenly not needed for WP4030U, but still needed for the
other two models?
Thanks,
--
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
