On Sun, Aug 8, 2010 at 06:07, Sergei Shtylyov wrote: > Mike Frysinger wrote: >> When CONFIG_USB_MUSB_OTG is disabled, gcc emits an unused warning about >> the local mbase variable. So add __maybe_unused to avoid this. > >> --- a/drivers/usb/musb/musb_core.c >> +++ b/drivers/usb/musb/musb_core.c >> @@ -704,7 +704,7 @@ static irqreturn_t musb_stage0_irq(struct musb *musb, >> u8 int_usb, >> #ifdef CONFIG_USB_MUSB_HDRC_HCD >> if (int_usb & MUSB_INTR_CONNECT) { >> struct usb_hcd *hcd = musb_to_hcd(musb); >> - void __iomem *mbase = musb->mregs; >> + void __iomem __maybe_unused *mbase = musb->mregs; >> handled = IRQ_HANDLED; >> musb->is_active = 1; > > There's patch for this issue already in Greg's queue: > > http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/usb/usb-musb-fix-compilation-warning-in-host-only-mode.patch > > Though yours seems somewhat better. either works for me. i'll roll with whatever is merged. -mike -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html