On Fri, Aug 06, 2010 at 06:26:42PM +0400, Michael Tokarev wrote:
> 06.08.2010 18:14, Greg KH wrote:
> []
> >> Sure thing, but before I'd want to know how to add that
> >> support properly (not how to format the patch :)
> >
> > Well, a patch would be nice so that others can use the device :)
>
> I'm fine with a patch, but I wanted to do it "properly" --
> I'd not say that exposing the 2 extra/unknown interfaces
> as serial interfaces is a proper way, some sort of "raw
> device" is better. But ok, here we go...
>
> The attached patch is against for 2.6.35 kernel. It'd
> be nice to have all these VENDOR_IDs and usb device table
> sorted somehow, instead of adding them at the end....
Why, it doesn't speed up anything, and makes it easier to merge patches.
> Signed-Off-By: Michael Tokarev <mjt@xxxxxxxxxx>
>
> Thanks!
>
> --- kernel-2.6.34/drivers/usb/serial/option.c.orig 2010-07-05 23:57:45.501593450 +0400
> +++ kernel-2.6.34/drivers/usb/serial/option.c 2010-08-06 13:39:24.892077680 +0400
> @@ -906,6 +906,11 @@
> { USB_DEVICE(CINTERION_VENDOR_ID, 0x0047) },
>
> { USB_DEVICE(OLIVETTI_VENDOR_ID, OLIVETTI_PRODUCT_OLICARD100) },
> +
> +#define CELOT_VENDOR_ID 0x211F
> +#define CELOT_PRODUCT_CT680M 0x6801
> + { USB_DEVICE(CELOT_VENDOR_ID, CELOT_PRODUCT_CT680M) },
Please don't put the #defines here, put them where the other ones are.
Care to redo this?
thanks,
greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
