Re: [PATCH 3/3] usb gadget: mark usb_composite_drivers with __refdata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Michał,

On Fri, Aug 06, 2010 at 10:45:00AM +0200, Michał Nazarewicz wrote:
> On Fri, 06 Aug 2010 08:40:41 +0200, Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> wrote:
>
>> The .bind callbacks usually live in .init.text.  This is OK as it is only
>> called at register time.  A proper fix would remove the bind member from
>> struct usb_composite_driver, but that doesn't work without much
>> reorganization, so mark them as refdata for now.
>
> I just realised that I misunderstood the __ref* tags.  The __ref* means that
> the thing references an __init* thing, correct?
That's what I tried to explain earlier in this thread.  And more exact
it means that modpost won't warn about structures/functions that are
marked with it.  It doesn't necessarily fixes the section mismatches.
That's why I don't like it and added a comment for each __refdata.

Best regards
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux