Re: [PATCH 14/25] langwell: USB Client Remote Wakeup Support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Aug 05, 2010 at 12:50:08PM +0100, Alan Cox wrote:
> > > +#if defined(CONFIG_USB_DEBUG)
> > > +	/* force remote wakeup enabled in case gadget driver
> > > doesn't support */
> > > +	spin_lock_irqsave(&dev->lock, flags);
> > > +	dev->remote_wakeup = 1;
> > > +	dev->dev_status |= (1 << USB_DEVICE_REMOTE_WAKEUP);
> > > +	spin_unlock_irqrestore(&dev->lock, flags);
> > > +#endif
> > 
> > Why is this a debug-only thing?
> 
> Would you prefer it out or generally available ?

I don't understand why it's a debug-only thing.  Is this a real problem
that you have to always do?  If so, then just do it, don't require
someone to rebuild their kernel just to get their hardware to work
correctly :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux