Re: [PATCH] xHCI: update ring dequeue pointer when process missed tds

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Aug 03, 2010 at 09:28:13AM -0700, Sarah Sharp wrote:
> On Mon, Aug 02, 2010 at 05:56:24PM +0800, Andiry Xu wrote:
> > >From dd491aae154bdb3805ad823a5776799aaafb7cda Mon Sep 17 00:00:00 2001
> > From: Andiry Xu <andiry.xu@xxxxxxx>
> > Date: Mon, 2 Aug 2010 17:35:00 +0800
> > Subject: [PATCH] xHCI: update ring dequeue pointer when process missed tds
> > 
> > This patch fixes a isoc transfer bug reported by Sander Eikelenboom.
> > When ep->skip is set, endpoint ring dequeue pointer should be updated
> > when processed every missed td. Although ring dequeue pointer will also
> > be updated when ep->skip is clear, leave it intact during missed tds
> > processing may cause two issues:
> > 
> > 1). If the very next valid transfer following missed tds is a short
> > transfer, its actual_length will be miscalculated;
> > 2). If there are too many missed tds during transfer, new inserted tds
> > may found the transfer ring full and urb enqueue fails.
> > 
> > Reported-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> > Tested-by: Sander Eikelenboom <linux@xxxxxxxxxxxxxx>
> > Signed-off-by: Andiry Xu <andiry.xu@xxxxxxx>
> 
> Signed-off-by: Sarah Sharp <sarah.a.sharp@xxxxxxxxxxxxxxx>

Can you resend this so that I can apply it?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux