On Mon, 26 Jul 2010, Sarah Sharp wrote: > On Mon, Jul 26, 2010 at 11:19:51AM -0400, Alan Stern wrote: > > Sarah: > > > > The programming interface for usb_alloc_streams() and > > usb_free_streams() seems a little strange: > > > > The functions accept a pointer to a usb_interface structure, > > but they immediately convert it to a pointer to a usb_device. > > Why not just take the usb_device pointer as an argument to > > begin with? > > Greg indicated that he wanted API to start passing around interfaces, > rather than devices. I believe the initial patches passed around a > usb_device pointer. Ah. That makes sense; I'm just not accustomed to it yet. > > Both routines take a mem_flags argument. Why is it needed > > in usb_free_streams()? The xhci_free_streams() routine doesn't > > use it. > > Noted in my todo list. Patches gladly accepted. :) As time permits... Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
