Re: [PATCH 1/2] USB - Option.c obey reserved interface flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday 23 July 2010, Greg KH wrote:
> On Fri, Jul 23, 2010 at 09:28:40AM +0100, Andrew Bird wrote:
> > Signed-off-by: Andrew Bird <ajb@xxxxxxxxxxxxxxxxxxx>
> 
> Is this a bugfix?  Doesn't this work today somehow, or is the code all
> broken?
> 
> i.e. I need more explanation for why this patch is needed.

Well currently the option driver defines the flag 
OPTION_BLACKLIST_RESERVED_IF, but nowhere is it referenced. If you want the 
option driver to avoid binding to a specific interface on a multifunction 
device, it seems you should set this and provide an array of interface numbers 
to avoid in the driver_info. The option driver will bind to any interface that 
is class 0xff that matches Vid/Pid. Reasons for not binding to an interface 
that isn't a com port are:
	a) you might want to bind another driver to it e.g. network device
	b) the device may get confused if a program tries to read/write/open the 
tty that's bound to it. e.g. wvdial or other program trying to determine the 
functionality as a modem.

Thanks,


Andrew
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux