On Wed, 21 Jul 2010, Stephen Warren wrote: > Phil Dibowitz wrote: > > On 07/18/2010 10:11 PM, Alan Stern wrote: > >> Aside from that, this is basically okay. There's a couple of things > >> in the patch itself you might want to consider changing: > > > > Great, thanks. All cosmetic, and done my local version. > > > > Stephen - as soon as you confirm the patch works (the second one, please, > > not the first, since they're non-cosmetic changes), I'll submit upstream. > > Sorry for the slow response; I had a heck of a time getting a kernel to > work on Ubuntu, and trying to track down why my debug prints weren't > appearing... > > Unfortunately, this patch does not work. > > udev->quirks is set up later than the newly added usage in > hub_port_connect_change, specifically in the usb_new_device call later in > the "for SET_CONFIG_TRIES" loop. Hence, there are no quirks set at that > time, and the workaround msleep() is never executed. Yes, that's a problem. We should be able to fix it, though, by moving the call to usb_detect_quirks from usb_new_device up into hub_port_connect_change, between hub_port_init and the new test. Stephen, can you make that change and test it? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
