On Wed, Jul 21, 2010 at 04:38:44PM -0400, Steven Robertson wrote: > Kernel: 2.6.35-rc5-git1 > > Enlarging the buffer size via the MON_IOCT_RING_SIZE ioctl causes > general protection faults. It appears the culprit is an incorrect > argument to mon_free_buff: instead of passing the size of the current > buffer being freed, the size of the new buffer is passed. Has this always been a problem, or did a recent change cause it to happen? Pete, any objections to the patch below? greg k-h > > -- > > Use the correct size argument to mon_free_buff when changing the size of > the buffer. > > Signed-off-by: Steven Robertson <steven@xxxxxxxxx> > > --- linux-2.6.35-rc5-git1/drivers/usb/mon/mon_bin.c.orig 2010-07-21 16:00:01.000000000 -0400 > +++ linux-2.6.35-rc5-git1/drivers/usb/mon/mon_bin.c 2010-07-21 16:02:45.915228398 -0400 > @@ -1009,7 +1009,7 @@ static int mon_bin_ioctl(struct file *fi > > mutex_lock(&rp->fetch_lock); > spin_lock_irqsave(&rp->b_lock, flags); > - mon_free_buff(rp->b_vec, size/CHUNK_SIZE); > + mon_free_buff(rp->b_vec, rp->b_size/CHUNK_SIZE); > kfree(rp->b_vec); > rp->b_vec = vec; > rp->b_size = size; > -- > To unsubscribe from this list: send the line "unsubscribe linux-usb" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
