On Mon, 19 Jul 2010, Michał Nazarewicz wrote:
> On Fri, 16 Jul 2010 10:25:27 +0200, Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> wrote:
> > Signed-off-by: Robert P. J. Day <rpjday@xxxxxxxxxxxxxx>
> >
> > ---
> >
> > since this is an obvious typo, might want to push it thru for next
> > release.
> >
> > diff --git a/drivers/usb/gadget/Makefile b/drivers/usb/gadget/Makefile
> > index 9bcde11..650b1b9 100644
> > --- a/drivers/usb/gadget/Makefile
> > +++ b/drivers/usb/gadget/Makefile
> > @@ -52,7 +52,7 @@ obj-$(CONFIG_USB_AUDIO) += g_audio.o
> > obj-$(CONFIG_USB_ETH) += g_ether.o
> > obj-$(CONFIG_USB_GADGETFS) += gadgetfs.o
> > obj-$(CONFIG_USB_FUNCTIONFS) += g_ffs.o
> > -obj-$(CONFIG_USB_ETH_FUNCTIONFS) += g_eth_ffs.o
> > +obj-$(CONFIG_USB_FUNCTIONFS_ETH) += g_eth_ffs.o
> > obj-$(CONFIG_USB_FILE_STORAGE) += g_file_storage.o
> > obj-$(CONFIG_USB_MASS_STORAGE) += g_mass_storage.o
> > obj-$(CONFIG_USB_G_SERIAL) += g_serial.o
>
> This is actually incorrect. There is no g_eth_ffs.c file and so the
> line should be removed altogether. I'm not sure why it ended in the
> Makefile in the first place (IIRC I've been developing to separate
> gadgets first and then used only the one with Ethernet).
ah, you're right, i missed that entirely. as for how that line
ended up in the Makefile in the first place, well, it does look like
you put it there. :-)
$ git show c6c56008
rday
--
========================================================================
Robert P. J. Day Waterloo, Ontario, CANADA
Top-notch, inexpensive online Linux/OSS/kernel courses
http://crashcourse.ca
Twitter: http://twitter.com/rpjday
LinkedIn: http://ca.linkedin.com/in/rpjday
========================================================================
