On Sun, 18 Jul 2010, Phil Dibowitz wrote:
> Inline this time. I think this addresses all your points.
>
> - Phil
>
>
> The Logitech Harmony 700 series needs a an extra delay during initialization.
> This adds a USB quirk which enabled such a delay, and adds the device to the
> quirks list.
Two more typos. Finding them is left as an exercise for the student. :-)
Aside from that, this is basically okay. There's a couple of things
in the patch itself you might want to consider changing:
> @@ -3109,6 +3110,10 @@ static void hub_port_connect_change(stru
> if (status < 0)
> goto loop;
>
> + if (udev->quirks & USB_QUIRK_DELAY_INIT) {
> + msleep(1000);
> + }
Braces aren't needed here.
> --- linux-2.6.35-rc5/include/linux/usb/quirks.h~usbcore-checkspeed-quirk 2010-07-18 16:00:15.000000000 +0200
> +++ linux-2.6.35-rc5-phil/include/linux/usb/quirks.h 2010-07-18 18:27:46.000000000 +0200
> @@ -26,4 +26,7 @@
> and can't handle talking to these interfaces */
> #define USB_QUIRK_HONOR_BNUMINTERFACES 0x00000020
>
> +/* device needs a pause before checking speed */
> +#define USB_QUIRK_DELAY_INIT 0x00000040
The comment should be updated to match the updated name.
Alan Stern
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
