Chuck: Thanks for the information. Sorry that we missed the patch. It was not done out of specific reason. As you have commented, it is a very large patch with alot of changes. We wanted to submit the patch to make sure the fundamental structure of the driver align with the kernel. Once that is in place, additional patch will be easier. Fushen will make sure this change is in place on the next submission. Thanks Feng Kan On Tue, Jul 13, 2010 at 3:16 PM, Chuck Meade <chuck@xxxxxxxxxxxxxxx> wrote: > > On 07/12/2010 07:16 PM, Fushen Chen wrote: > > The DWC OTG driver module provides the initialization and cleanup > > entry points for the DWC OTG USB driver. > > > > Signed-off-by: Fushen Chen <fchen@xxxxxxx> > > Signed-off-by: Mark Miesfeld <mmiesfeld@xxxxxxx> > > --- > > This reply is to the patch series, not just this 1/9 patch section. > > Fushen, why did you pick and choose which fixes to incorporate from the Denx > tree's version of the dwc_otg driver? > > I'm not taking the time here to go through this multipart patch and check that > you incorporated every fix, but I *did* randomly pick one fix that I made to that > driver, to see if you incorporated it, and it appears you did not. > I would have expected that you would have incorporated the fixes that were made > to this driver in the Denx tree. > > The one that I checked is in the data toggle error interrupt handling, in > handle_hc_chhltd_intr_dma() (see your 5/9 email in this patch series). It looks > like you left out the fix I made to this logic that averts an interrupt storm. > > I assume that since I checked one particular fix, and it was missing from your > patch series, that there are likely more fixes you omitted. Can you explain why > you would leave this out, after Stefan asked you to incorporate the code changes > made in the Denx tree's version of the driver? > > Chuck > _______________________________________________ > Linuxppc-dev mailing list > Linuxppc-dev@xxxxxxxxxxxxxxxx > https://lists.ozlabs.org/listinfo/linuxppc-dev -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
