On Fri, Jun 25, 2010 at 04:48:37PM +0800, Andiry Xu wrote: > Hi Sarah, > > This is xHCI isoc transfer implementation patchset v7. > > Changelog from v6: > 1. Break the xHCI: handle_tx_event() refine patch into six smaller > patches. > > Again, this patchset is based on revert-link-trb branch, > commit 5162708fc3c0. I assume you based your work off the revert-link-trb branch because you ran into issues with overwriting the link TRBs when queueing isochronous transfers. However, the patches on that branch are not going to be merged. They were just a quick test to see if the link TRB change was an issue for someone. The patches to fix the known bugs in the link TRB handoff change from John have been sent to Greg, and one has already been sent out by Linus. I don't want to revert John's patch, as it's needed for streams communications to work properly. So you're going to have to add a patch to work around the isochronous issues with John's patch. I think the patch will be similar to the control transfer fix (commit 6cc30d85a5bf61248ff0e1f0e0f15fe718bae378 in Linus' tree). Basically, you need to indicate to queue_trb() whether more TDs are coming if you're going to queue multiple isochronous TDs without calling prepare_transfer() in between each TD. I've updated my master branch to be against 2.6.35-rc4, with some additional bug fixes that Greg has queued. Can you please base your next patch set against that? I'll send more comments on the isoc patchset later today so you can do the changes all at once. Thanks, Sarah Sharp -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
