Re: [PATCH] usb-storage: fix initializations of urb fields

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 12, 2010 at 11:18:18AM -0400, Bob Copeland wrote:
> Commit 0ede76fcec5415ef82a423a95120286895822e2d, "USB: remove uses of
> URB_NO_SETUP_DMA_MAP" introduced a regression by inadvertantly removing
> initialization of the transfer flags.  This caused initialization
> failures in the ums-karma driver.  Fix the regression by zeroing it.
> 
> While at it, as Alan Stern points out, the initializers for
> actual_length and status are handled by the core and error_count
> only matters for isochronous urbs, so they don't need to be set here.
> Remove them.
> 
> Signed-off-by: Bob Copeland <me@xxxxxxxxxxxxxxx>
> ---
> 
> Hey all,
> 
> I didn't know who might take the patch so I CCed a few guesses.
> It would be nice to get this in 2.6.35 or at least .35.x since it
> is a regression in current mainline.

I'll take it and try to get it into .35.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux