Gupta, Ajay Kumar wrote:
I am trying to use definitions at ulpi.h in drivers/usb.host/ehci-omap.c
For soft resetting the ULPI phy but I am getting below compilation warning.
include/linux/usb/ulpi.h:145: warning: 'struct otg_io_access_ops' declared inside parameter list
include/linux/usb/ulpi.h:145: warning: its scope is only this definition or declaration, which is probably not what you want
This sounds like ulpi.h fails to #include <linux/usb/otg.h>.
[ehci-omap.c is not suppose to include otg.h file]
The header file's dependencies should be satisfied within the header file
itself, not by the code including it.
ulpi.h:145 has declaration of otg_ulpi_create().
As 'struct otg_io_access_ops' is defined in otg.h so will it be fine to move
Declaration of otg_ulpi_create() from ulpi.h to otg.h to fix the above
issue?
No, it won't be fine I think.
Thanks,
Ajay
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
