On 06/27/10 17:00, Eric Bénard wrote: > Le 27/06/2010 09:42, Igor Grinberg a écrit : >> >> On 06/24/10 17:37, Eric Bénard wrote: >>> Le 24/06/2010 16:04, Igor Grinberg a écrit : >>>> ulpi_set_flags is used to set the OTG flags and not to clear them, >>>> also it is a static function and is not a part of struct >>>> otg_transceiver, >>>> so it cannot be called from outside the ulpi.c, thus after the >>>> ulpi_create, >>>> it is never called. >>>> I think, currently, this should stay as it is. >>>> >>> OK, the problem that when one flag is set, you can't clear it without >>> resetting the PHY. >> >> This is correct, but current ulpi driver is not designed for writing >> multiple times >> into the ULPI_OTG_CTRL register, only once when ulpi_init function is >> called. >> Do you call the ulpi_init function for a couple of times? Looks like >> a hack. >> > no hack, as I was fixing the other function, I though this one could > also be fixed :) > I'll send a patch with only the other fix. > > Eric > I've found in the ulpi specification that there are some bits in the OTG Control Register that are set by default after power-on. Current ulpi driver can only set those bits and not clear them, making it impossible for the platform to clear them even at initialization time. So, after all v2 of your patch is correct. Sorry, for not seeing this at first time :( , so Acked-by: Igor Grinberg <grinberg@xxxxxxxxxxxxxx> -- Regards, Igor. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
