> >+/* ULPI Function Control set register */ > >+#define FUNCTION_CTRL_SET_OFFSET 0x5 > >+#define ULPI_FUNCTION_CTRL_SET_SUSPENDM (1 << 6) > >+#define ULPI_FUNCTION_CTRL_SET_RESET (1 << 5) > >+#define ULPI_FUNCTION_CTRL_SET_OPMODE (3 << 3) > >+#define ULPI_FUNCTION_CTRL_SET_TERMSELECT (1 << 2) > >+#define ULPI_FUNCTION_CTRL_SET_XCVRSELECT (3 << 0) > > you can use the helpers in <linux/usb/ulpi.h> for these too: > > ULPI_SET(ULPI_FUNC_CONTROL); Ok fine. I will do the necessary changes and would submit v2 of this patch. Thanks, Ajay > > -- > balbi > > DefectiveByDesign.org -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html