Re: [PATCH 1/3] USB: s3c2410_udc: eliminate sleep in irq context

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Tue, Jun 29, 2010 at 2:41 PM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
> Vladimir Zapolskiy wrote:
>
>> Processing of ep0 resurrection after stall is done directly from irq
>> handler, it is mandatory to remove usleep call.
>
>> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx>
>
> [...]
>>
>> diff --git a/drivers/usb/gadget/s3c2410_udc.c
>> b/drivers/usb/gadget/s3c2410_udc.c
>> index e724a05..b1b4d00 100644
>> --- a/drivers/usb/gadget/s3c2410_udc.c
>> +++ b/drivers/usb/gadget/s3c2410_udc.c
>> @@ -749,7 +749,6 @@ static void s3c2410_udc_handle_ep0_idle(struct
>> s3c2410_udc *dev,
>>                        dprintk(DEBUG_NORMAL,
>>                                "dev->driver->setup failed. (%d)\n", ret);
>>  -              udelay(5);
>
>   But this is udelay(), not usleep()?

thank you very much for the review, that's my fault, obvious for now.

I think this series of patches could be dropped, and the single actual
fix I'll send separately.

With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux