RE: [PATCH 4/4]usb : musb:USB driver using omap_device_build for device registration.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



 

>-----Original Message-----
>From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] 
>Sent: Monday, June 28, 2010 7:12 PM
>To: Kalliguddi, Hema
>Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Felipe Balbi
>Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
>omap_device_build for device registration.
>
>* Kalliguddi, Hema <hemahk@xxxxxx> [100628 16:26]:
>>  
>> 
>> >-----Original Message-----
>> >From: Tony Lindgren [mailto:tony@xxxxxxxxxxx] 
>> >Sent: Monday, June 28, 2010 6:59 PM
>> >To: Kalliguddi, Hema
>> >Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; 
>Felipe Balbi
>> >Subject: Re: [PATCH 4/4]usb : musb:USB driver using 
>> >omap_device_build for device registration.
>> >
>> >* Hema HK <hemahk@xxxxxx> [100628 15:12]:
>> >> -
>> >> -	/*
>> >> -	 * REVISIT: This line can be removed once all the 
>> >platforms using
>> >> -	 * musb_core.c have been converted to use use clkdev.
>> >> -	 */
>> >> -	musb_plat.clock = "ick";
>> >
>> >This comment is still valid, please don't remove it.
>> This is still there. It is moved below under else.
>
>Not in the patch you posted?
>

-	musb_plat.clock = "ick";
-	musb_plat.board_data = board_data;
-	musb_plat.power = board_data->power >> 1;
-	musb_plat.mode = board_data->mode;
-	musb_plat.extvbus = board_data->extvbus;
-
-	if (platform_device_register(&musb_device) < 0)
-		printk(KERN_ERR "Unable to register HS-USB (MUSB) device\n");
+	char oh_name[MAX_OMAP_MUSB_HWMOD_NAME_LEN];
+	struct omap_hwmod *oh;
+	struct omap_device *od;
+	struct platform_device *pdev;
+	struct device	*dev;
+	int l, bus_id = -1;
+	struct musb_hdrc_platform_data *pdata;
+
+	l = snprintf(oh_name, MAX_OMAP_MUSB_HWMOD_NAME_LEN,
+						"usb_otg_hs");
+	WARN(l >= MAX_OMAP_MUSB_HWMOD_NAME_LEN,
+	"String buffer overflow in MUSB device setup\n");
+	oh = omap_hwmod_lookup(oh_name);
+	if (!oh) {
+		pr_err("Could not look up %s\n", oh_name);
+	} else {
+		musb_plat.clock = "ick";
+		musb_plat.board_data = board_data;
+		musb_plat.power = board_data->power >> 1;
+		musb_plat.mode = board_data->mode;
+		pdata = &musb_plat;

It is there in the patch I posted.only the comment is being removed. You are refering the comment also? 

Regards,
Hema
>Tony
>--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux