Thanks for the suggestions. I'll resend the patches. Thanks & Best regards, Andiry > -----Original Message----- > From: Sarah Sharp [mailto:sarah.a.sharp@xxxxxxxxxxxxxxx] > Sent: Thursday, June 24, 2010 1:25 AM > To: Xu, Andiry > Cc: linux-usb@xxxxxxxxxxxxxxx; gregkh@xxxxxxx > Subject: Re: [PATCH 1/4 v6] xHCI: handle_tx_event() refine > > Can you please separate the refactoring, print removal, and adding new > features into different patches? > > I would actually like to see the refactoring process in several smaller > patches. E.g. here is a patch to move the control transfer processing > into a separate function, here is another patch to move the bulk > processing into a separate function, here is a third patch to remove > redundant printing messages. That way reviewers can easily see whether > the refactoring looks correct. With this giant patch, I can't easily > tell what you did. (And it will definitely take me longer to review.) > > Sarah Sharp > -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
