Koen Kooi wrote: > Op 23 jun 2010, om 22:33 heeft Kevin Hilman het volgende geschreven: > > David Anders <x0132446@xxxxxx> writes: > > > >> Add select statement to force selection of NOP_USB_XCEIV for OMAP4. > >> > >> Signed-off-by: David Anders <x0132446@xxxxxx> > >> --- > >> drivers/usb/musb/Kconfig | 1 + > >> 1 files changed, 1 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig > >> index cfd38ed..e4624bc 100644 > >> --- a/drivers/usb/musb/Kconfig > >> +++ b/drivers/usb/musb/Kconfig > >> @@ -11,6 +11,7 @@ config USB_MUSB_HDRC > >> depends on (USB || USB_GADGET) > >> depends on (ARM || (BF54x && !BF544) || (BF52x && !BF522 && !BF523)) > >> select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN) > >> + select NOP_USB_XCEIV if ARCH_OMAP4 > >> select TWL4030_USB if MACH_OMAP_3430SDP > >> select USB_OTG_UTILS > >> tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)' > > > > Shouldn't this be a board-specific option, and not set for every > > OMAP4-based config? > > If that's true, why do the davinci and blackfin archs force it? > Kevin's right. For OMAP4 at least, this is something that is probably' best left up to the board to select. For the davinci's and blackfins, they don't have an option. They have a fully transparent internal PHY which doesn't need any configuring. However, with the OMAP4, you could potentially use an external ULPI transceiver. This can be another transparent PHY for which we could select the NOP_XCEIV. Or it could be something like the PHY in the TWL5030 which may need configuring over an I2C interface. - Anand -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
