RE: [PATCH] select NOP_USB_XCEIV for OMAP4

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: Kevin Hilman [mailto:khilman@xxxxxxxxxxxxxxxxxxx]
> Sent: Wednesday, June 23, 2010 3:33 PM
> To: Anders, David
> Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx; Gupta, Ajay
> Kumar; felipe.balbi@xxxxxxxxx
> Subject: Re: [PATCH] select NOP_USB_XCEIV for OMAP4
> 
> David Anders <x0132446@xxxxxx> writes:
> 
> > Add select statement to force selection of NOP_USB_XCEIV for OMAP4.
> >
> > Signed-off-by: David Anders <x0132446@xxxxxx>
> > ---
> >  drivers/usb/musb/Kconfig |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/drivers/usb/musb/Kconfig b/drivers/usb/musb/Kconfig
> > index cfd38ed..e4624bc 100644
> > --- a/drivers/usb/musb/Kconfig
> > +++ b/drivers/usb/musb/Kconfig
> > @@ -11,6 +11,7 @@ config USB_MUSB_HDRC
> >  	depends on (USB || USB_GADGET)
> >  	depends on (ARM || (BF54x && !BF544) || (BF52x && !BF522 && !BF523))
> >  	select NOP_USB_XCEIV if (ARCH_DAVINCI || MACH_OMAP3EVM || BLACKFIN)
> > +	select NOP_USB_XCEIV if ARCH_OMAP4
> >  	select TWL4030_USB if MACH_OMAP_3430SDP
> >  	select USB_OTG_UTILS
> >  	tristate 'Inventra Highspeed Dual Role Controller (TI, ADI, ...)'
> 
> Shouldn't this be a board-specific option, and not set for every
> OMAP4-based config?
> 

As I understand it, any of the omap4 devices that are using the Inventra need to have at a minimum of the NOP USB Transceiver. Enabling the NOP transceiver doesn't preclude the use of other external transceivers. The NOP USB Transceiver will still need to be registered in the board-specific machine file therefore doesn't impact a board that doesn't use it.

Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux