On Fri, Jun 18, 2010 at 12:31:02PM +0200, Michał Nazarewicz wrote: > On Thu, 17 Jun 2010 19:51:01 +0200, Greg KH <greg@xxxxxxxxx> wrote: > > >On Wed, Jun 16, 2010 at 12:08:01PM +0200, Michal Nazarewicz wrote: > >>The Multifunction Compasite Gadget have been cleaned up > >>and refactored so hopefully it looks prettier and works > >>at least as good as before changes. > >> > >>Signed-off-by: Michal Nazarewicz <m.nazarewicz@xxxxxxxxxxx> > >>Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > >>--- > >> drivers/usb/gadget/Kconfig | 1 + > >> drivers/usb/gadget/multi.c | 262 +++++++++++++++++++++++++------------------- > >> 2 files changed, 148 insertions(+), 115 deletions(-) > >> > >>diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig > >>index 591ae9f..027f61b 100644 > >>--- a/drivers/usb/gadget/Kconfig > >>+++ b/drivers/usb/gadget/Kconfig > >>@@ -863,6 +863,7 @@ config USB_G_NOKIA > >> config USB_G_MULTI > >> tristate "Multifunction Composite Gadget (EXPERIMENTAL)" > >> depends on BLOCK && NET > >>+ select USB_G_MULTI_CDC if !USB_G_MULTI_RNDIS > >> help > >> The Multifunction Composite Gadget provides Ethernet (RNDIS > >> and/or CDC Ethernet), mass storage and ACM serial link > > > >Why is this change needed? Did you do something else in this patch that > >requires it? > > Without this select it is possible to choose neither RNDIS nor CDC ECM which > in turns builds a module with no configurations. Then you need to say that in the changelog portion of the patch submission :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
