Re: [PATCH] USB: s3c2410: deactivate endpoints before gadget unbinding

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello,

On Fri, Jun 18, 2010 at 1:36 AM, Sergei Shtylyov <sshtylyov@xxxxxxxxxx> wrote:
> Hello.
>
> Vladimir Zapolskiy wrote:
>
>> Gadget disconnect must be called before unbinding to avoid races.
>> The change fixes an oops on g_ether module unregistering.
>
>> Signed-off-by: Vladimir Zapolskiy <vzapolskiy@xxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxx>
>
>> diff --git a/drivers/usb/gadget/s3c2410_udc.c
>> b/drivers/usb/gadget/s3c2410_udc.c
>> index d5f4c1d..b45da70 100644
>> --- a/drivers/usb/gadget/s3c2410_udc.c
>> +++ b/drivers/usb/gadget/s3c2410_udc.c
>> @@ -1700,9 +1700,13 @@ int usb_gadget_unregister_driver(struct
>> usb_gadget_driver *driver)
>>        if (!driver || driver != udc->driver || !driver->unbind)
>>                return -EINVAL;
>>  -      dprintk(DEBUG_NORMAL,"usb_gadget_register_driver() '%s'\n",
>> +       dprintk(DEBUG_NORMAL,"usb_gadget_unregister_driver() '%s'\n",
>
>   Shouldn't there be a space after comma?
>
Sure, thank you a lot.

Best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux