Hello.
Maulik wrote:
-----Original Message-----
From: Sergei Shtylyov [mailto:sshtylyov@xxxxxxxxxx]
Sent: Thursday, June 17, 2010 4:57 PM
To: Ajay Kumar Gupta
Cc: linux-usb@xxxxxxxxxxxxxxx; linux-omap@xxxxxxxxxxxxxxx;
felipe.balbi@xxxxxxxxx; gregkh@xxxxxxx; Maulik Mankad; David Brownell
Subject: Re: [PATCH 8/8] usb: musb: Fix suspend interrupt issue in device
mode
Hello.
Ajay Kumar Gupta wrote:
From: Maulik Mankad <x0082077@xxxxxx>
As a part of aligning the ISR code for MUSB with the specs, the
ISR code was re-written.
See Commit 1c25fda4a09e8229800979986ef399401053b46e (usb: musb: handle
irqs in the order dictated by programming guide)
With this the suspend interrupt came accidently under
CONFIG_USB_MUSB_HDRC_HCD.
The fix brings suspend interrupt handling outside
CONFIG_USB_MUSB_HDRC_HCD.
Signed-off-by: Maulik Mankad <x0082077@xxxxxx>
Acked-by: Felipe Balbi <felipe.balbi@xxxxxxxxx>
Cc: David Brownell <david-b@xxxxxxxxxxx>
Signed-off-by: Ajay Kumar Gupta <ajay.gupta@xxxxxx>
[...]
diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c
index 4f43db7..64b08f9 100644
--- a/drivers/usb/musb/musb_core.c
+++ b/drivers/usb/musb/musb_core.c
@@ -635,7 +635,7 @@ static irqreturn_t musb_stage0_irq(struct musb
*musb, u8 int_usb,
handled = IRQ_HANDLED;
}
-
+#endif
Could you move #endif one line up, so that it closely embraces the
*if* statement?
The patch is already in Greg's queue.
Hm, how come it ended up there before the patches submitted earlier
-- namely before the patch that's needed for the suspend interrupt to be
handled at all? :-/
Felipe, could you also ACK the other pending patches, not this
single one?
Greg,
Do you want me to resend this patch?
Thanks,
Maulik
WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
