On Tue, Jun 15, 2010 at 12:43:42PM +0200, Daniel Mack wrote: > On Tue, Jun 15, 2010 at 12:34:23PM +0200, Wolfram Sang wrote: > > The old code registered the hcd even if there were no transceivers > > detected, leading to oopses like this if we try to probe a non-existant > > ULPI: > > Hmm. I'm aware that there was a missing bail in this function, but > actually, I had hardware which didn't properly detect the ULPI chip but > still worked fine. There has been quite some discussion here about that, > and eventually I decided to not make this a hard error as it didn't > really harm. My use case is that we have two very similar boards, one uses just the second host controller, the other one uses also OTG. Of course, we'd like to have just one kernel, so we wanted to check if probing for OTG fails gracefully enough, if the ULPI is not present. It did not, so this is what my patch intends to fix. I think, checking why your boards fail to do the init, is the cleaner way to go in the long run. Regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
