Re: [PATCH] <linux/usb/gadget.h>: add missing #include's

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello.

Greg KH wrote:

When #include'd alone, <linux/usb/gadget.h> causes a lot of compilation errors
and warnings -- all because it relies on the including code to bring in the
necessary #include's instead of doing this itself.

That's normal,

We have different definitions of normality, it seems. To me, it's not normal when I have to figure out what to #include in a driver every time just to satisfy one of the #include's dependencies. I'd better do it once only, in that #include itself.

we don't always want to include all dependant .h files in
the .h files, otherwise it gets very messy, and people have been trying
to clean this up over time.

   Hm...

Is this causing a build error somewhere?

   I'm developing a new gadget driver, and bumped into this.

thanks,

greg k-h

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux