On Thu, Jun 03, 2010 at 02:38:27AM +0200, Frederic Weisbecker wrote: > This should be simply dropped and we can make use of generic_file_llseek > instead, as the fallback llseek. generic_file_llseek contains the sb->s_maxbytes check, so it needs at least a careful audit first. But as mentioned about a dozend times before it's an just as bad default. The correct default to go ahead it to not allow seeking and pread/pwrite unless a ->lseek method is set, and I've already explained a step by step guide how to get there in easily bisectable steps. And the addition of nonseekable_open/no_llseek by you BKL guys already got us much closer to this, so please follow up on that work and do it properly. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
