RE: [PATCH 1/3 v3] AM35x: Add musb support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,
[..]
> > +	 * We have to override VBUS/ID signals when MUSB is configured into
> the
> > +	 * host-only mode -- ID pin will float if no cable is connected, so
> the
> > +	 * controller won't be able to drive VBUS thinking that it's a B-
> device.
> > +	 * Otherwise, we want to use the OTG mode and enable VBUS
> comparators.
> > +	 */
> > +	devconf2 &= ~CONF2_OTGMODE;
> > +#ifdef	CONFIG_USB_MUSB_HOST
> > +	devconf2 |=  CONF2_FORCE_HOST;
> 
>     Well, this is only necessary if the board doesn't have pulldown on
> the USB ID signal. On DA830 EVM, rev. of the board A had it, and it got
> removed on the later revisions (presumably it conflicted with OTG
> function?), so this override became necessary. So, make sure this is
> indeed necessary on your board as using the overrides isn't generally
> desirable (they all also override VBUS sensing in addition to ID pin).

Yes, it's not needed for AM3517EVM

-Ajay
> 
> > +#else
> > +	devconf2 |=  CONF2_SESENDEN | CONF2_VBDTCTEN;
> > +#endif
> > +
> > +	omap_ctrl_writel(devconf2, AM35XX_CONTROL_DEVCONF2);
> > +
> > +	usb_musb_init(&musb_board_data);
> > +}
> > +
> >  static const struct ehci_hcd_omap_platform_data ehci_pdata __initconst
> = {
> >  	.port_mode[0] = EHCI_HCD_OMAP_MODE_PHY,
> >  #if defined(CONFIG_PANEL_SHARP_LQ043T1DG01) || \
> 
> WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Media]     [Linux Input]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]     [Old Linux USB Devel Archive]

  Powered by Linux