On Fri, 7 May 2010, Alan Stern wrote: > Although the usbhid driver allocates its usbhid structure in the probe > routine, several critical fields in that structure don't get > initialized until usbhid_start(). However if report descriptor > parsing fails then usbhid_start() is never called. This leads to > problems during system suspend -- the system will freeze. > > This patch (as1378) fixes the bug by moving the initialization > statements up into usbhid_probe(). > > Signed-off-by: Alan Stern <stern@xxxxxxxxxxxxxxxxxxx> > Reported-by: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> > Tested-By: Bruno Prémont <bonbons@xxxxxxxxxxxxxxxxx> I have fixed UTF-8 your mailer has mangled in Bruno's name and applied the patch, thanks a lot. > > This very much reminds me the resume issue with the same keyboard on a > > !CONFIG_SMP system back in February when the fix was to copy/move > > usbhid->intf = intf; from usbhid_start() to usbhid_probe()! > > Yes indeed, I had exactly the same thought. > > > Hopefully these are all those initializations that need to be taken > > care of... > > I looked and didn't see any others. > > Jiri, this clearly is needed for 2.6.34. Absolutely. Pull request is on its way already. Thanks, -- Jiri Kosina SUSE Labs, Novell Inc. -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
