On Fri, 7 May 2010, Du, Alek wrote: > Alan, > > As I tested, with the second patch, after entering phy low power mode, the port cannot detect any USB devices that plugged in. Ooh, that's not good. It almost violates the EHCI spec (see the last line on p.60 in table 4.4). > I also confirm that after set PHCD flag, any write to PORTSC is illegal. (I have another patch will send out soon named "Clear PHCD before resuming", > but the patch is not related with this one) I'm afraid we are going to have to modify the wakeup bits in PORTSC after PHCD is set. Can we clear PHCD, modify PORTSC, and then set PHCD again? > So it seems wakeup bits must set before set PHCD. So we may revise the flowchart a little bit, for example, if the HCD has hostpc, > then set the wakeup bits like before, if the HCD is the normal one, then go your new way? For normal HCDs, the wakeup bits don't matter when the controller is in D0. Therefore we can continue to set them as before during bus or port suspend. But during controller suspend, if the controller isn't supposed to be remote-wakeup-enabled then we will need to clear the wakeup bits (and set them again during controller resume). Will that work? Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
